sapmentors / lemonaid

SAP Mentors Lemonaid
MIT License
29 stars 16 forks source link

Search / filter issues #82

Closed qmacro closed 3 years ago

qmacro commented 6 years ago

The $filter value for the OData query operation on the Mentors entity set specifies a lot of properties to search across. These properties are:

Arguably only FullName and ShirtNumber are appropriate for searching; the others ought to be filterable entities with a filter mechanism that has yet to be added.

Also, the large value for $filter that is created because of the multiple search properties above results in errors in the search anyway - for example, searching for 'adams' only returns DJ Adams, when in fact there are two Adams mentors (Corey Adams too).

My suggestion is to address this by

  1. Remove inappropriate search property criteria so searching works as expected
  2. Add a filter mechanism to allow filtering by RelationshipToSap, MentorStatus and SapExpertise

I'll start with point 1 today.

gregorwolf commented 6 years ago

I would guess that was the reason the had client side filtering as that seems to work better on this point. Would be great if we can get also 2. before change 1.

qmacro commented 6 years ago

Turns out that a new filter on Mentor Status is not needed - this is provided by the icon tab filters already (statuses: Active, Alumni, Program). We could do with one on the SAP Expertise info, though.