sapondanaisriwan / AdashimaaTube

Restore old Youtube layout in 2021-2022 with many customizable options.
MIT License
298 stars 16 forks source link

[Bug]: Shorts are grouped at the top in subscriptions #144

Closed Usv3re closed 1 year ago

Usv3re commented 1 year ago

Describe the bug

So just today this happened to me - and I cannot turn this off. I think it were like that on the main page, but I were able to disable it there. Cannot do the same in subscriptions, I tried all the settings and no result

Screenshots

изображение

What browser are you using?

Mozilla Firefox 115.0.2 (x64)

What version of AdashimaaTube are you using?

v2.3.4

Usv3re commented 1 year ago

So the damned thing is called shorts shelf and it is soooo irritating. Looking forward to disable shorts shelf in the options, will use another additional style for now

Or maybe just add a button to show/hide the short shelf

Also you could make an upper left tab for subscription shorts as an option, I think many folks would like that. I certainly would

re11ding commented 1 year ago

Using the "Hide shorts" option fixes this, however it would be nice to be able to shrink it down and make it take less space as an alternative option.

jenci8888 commented 1 year ago

Mine slightly different from your issue, I used 4 styles and 10 tampermonkey. Although, "shorts" on subscription cannot be remove or hide unless if I have to remove shorts via HTML manually. Either, I will look up the latest plugin. Used Chrome 114.0.5735.199 and my settings: image image

image image

re11ding commented 1 year ago

The more scripts you have on and the more stylesheets you have active, the higher of a chance that conflicts will occur. I'm more certain this is a conflict issue in your case @jenci8888

Try disabling everything but AdashimaaTube and then see if the "Remove Shorts" option works.

Usv3re commented 1 year ago

Using the "Hide shorts" option fixes this, however it would be nice to be able to shrink it down and make it take less space as an alternative option.

I don't have that though

sapondanaisriwan commented 1 year ago

Using the "Hide shorts" option fixes this, however it would be nice to be able to shrink it down and make it take less space as an alternative option.

I don't have that though

image

sapondanaisriwan commented 1 year ago

If I don't group the shorts shelf or another shelf at the top, it will leave some empty spaces(You can disable the "Layout fix" option to see the problem).

re11ding commented 1 year ago

If I don't group the shorts shelf or another shelf at the top, it will leave some empty spaces(You can disable the "Layout fix" option to see the problem).

Yeah, I noticed that too. There's not much you could do about that either due to the way youtube renders the subscription page either. Maybe you could, but it'd be a ton of unnecessary work when you could just have it at the top. That's why I was saying a thing that makes it smaller would be awesome. Let me see if I can fiddle with the CSS on the main page to create some rules that'll suit that need.

sapondanaisriwan commented 1 year ago

It would take too much effort to fix everything with CSS. The best way to fix the issue is to create a new calcElementsPerRow function and replace the one used by YouTube. You can view the source code from here image

re11ding commented 1 year ago

No worries, that's fine. It's fine just sitting at the top. I just appreciate that you even allow the modification of the amount of videos displayed on a page for subscriptions to begin with.

TecnikOfficial commented 1 year ago

yes from yesterday shorts are appearing as vertical video in subscription page before it was as normal video thumbnail.. please can we get a feature where shorts appear as normal video thumbnail in subscription page pls

re11ding commented 1 year ago

yes from yesterday shorts are appearing as vertical video in subscription page before it was as normal video thumbnail.. please can we get a feature where shorts appear as normal video thumbnail in subscription page pls

Probably not going to happen as that was a change on Youtube's end, not here. It's way too complicated of a process to get it working like that again.

Usv3re commented 1 year ago

Oh thank you! Damn, don't know how I missed this

Usv3re commented 1 year ago

yes from yesterday shorts are appearing as vertical video in subscription page before it was as normal video thumbnail.. please can we get a feature where shorts appear as normal video thumbnail in subscription page pls

Probably not going to happen as that was a change on Youtube's end, not here. It's way too complicated of a process to get it working like that again.

What about making a shelf vertical on the side? smth like that 3425235423

re11ding commented 1 year ago

That's far outside the scope of AdashimaaTube. CSS alone cannot accomplish that. It would have to be an extension/userscript due to having to change the inner structuring of how youtube generates its layout. Worse yet, youtube pages are almost completely generated by a script in of itself, making overriding its generation process far more difficult than one would like. I would know. I originally tried creating a custom script to preserve the old youtube video page layout to give you the same look AdashimaaTube does for video titles and descriptions as a lot of the scripts simply re-enable the dormant HTML google left in there of the old design. Sadly, I was not able to do this as I couldn't inject things correctly. I'm not experienced enough in userscript to make something like you're requesting as a result work.

Fred-Vatin commented 1 year ago

If you want to hide it, use this code.

    ytd-browse[page-subtype="subscriptions"] #contents > ytd-rich-section-renderer:nth-of-type(2) {
        display: none !important;
    }
TecnikOfficial commented 1 year ago

no i dont want to hide my subscription shorts ... i already hide all the other shorts but just need my subscription shorts to be displayed

TecnikOfficial commented 1 year ago

yes from yesterday shorts are appearing as vertical video in subscription page before it was as normal video thumbnail.. please can we get a feature where shorts appear as normal video thumbnail in subscription page pls

Probably not going to happen as that was a change on Youtube's end, not here. It's way too complicated of a process to get it working like that again.

ok but if this was possible than it will give me a real reason to use ur userscript coz old ui i can get by just using this code on my enchancer for youtube extension or just putting it in ubo for more videos per rows use code in ubo

TecnikOfficial commented 1 year ago

yes from yesterday shorts are appearing as vertical video in subscription page before it was as normal video thumbnail.. please can we get a feature where shorts appear as normal video thumbnail in subscription page pls

Probably not going to happen as that was a change on Youtube's end, not here. It's way too complicated of a process to get it working like that again.

What about making a shelf vertical on the side? smth like that 3425235423

ya this is pretty good idea if change shorts thumbnail back to normal is not possible

TecnikOfficial commented 1 year ago

one thing u can do is try piped extractor to extract youtube thumbnail like piped.video still hav tht layout ( i know its not possible in this project if someone can pls try )