Improve documentation for PyPREP/MatPREP highpass differences

[a-hurst]

PR Description

Closes #107. This PR updates the docs to contain a better explanation of the differences between PyPREP's and MatPREP's trend removal filters (and why the MNE method is technically preferable).

Wasn't sure if this warranted an addition in the whats_new.rst, but if it does I can definitely add a line!

Merge Checklist

• [x] the PR has been reviewed and all comments are resolved
• [x] all CI checks pass
• [x] (if applicable): the PR description includes the phrase closes #<issue-number> to automatically close an issue
• [ ] (if applicable): bug fixes, new features, or API changes are documented in whats_new.rst

[a-hurst]

Er, looks like MNE needs an additional module to download test datasets now? Should I add that to this PR as well?

[sappelhoff]

ah right :thinking: yes please - we can just add it here: https://github.com/sappelhoff/pyprep/blob/master/requirements-dev.txt

[sappelhoff]

although pooch may soon be installed automatically when we install mne, see: https://github.com/mne-tools/mne-python/pull/10199

but no harm in adding it now to merge this PR, and then removing it again some time in the future when we don't need to declare it explicitly anymore.

[a-hurst]

Whoops, looks like matplotlib's changed its API on us since last update too. I'll try to tackle that as well.

[codecov-commenter]

Codecov Report

Merging #110 (301c458) into master (12047bf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files           7        7           
  Lines         733      733           
=======================================
  Hits          726      726           
  Misses          7        7           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12047bf...301c458. Read the comment docs.

[sappelhoff]

Thank you :)