mscheltienne commented 2 years ago

Closes #105.

I had this on my namespace for a while... (Oct 22. 2021) and I didn't take the time to finish it. If I recall correctly, it's missing the ProgressBar class for the 10%... 20%... 30%... print output by the RANSAC (probably the most annoying one when I run this on 40 cores 😅). I'll double-check the diff, make sure I didn't miss anything and add the ProgressBar for RANSAC.

Mathieu

mscheltienne commented 2 years ago

Also have to fix a couple of logs, as it seems I just did a replace

mscheltienne commented 2 years ago

Looks like this is working. And it is disabled if I change the loglevel of MNE. Test are green local.

codecov-commenter commented 2 years ago

Codecov Report

Merging #112 (0046dff) into master (4a91d31) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   99.04%   99.02%   -0.02%     
==========================================
  Files           7        7              
  Lines         733      719      -14     
==========================================
- Hits          726      712      -14     
  Misses          7        7

Impacted Files	Coverage Δ
pyprep/utils.py	`100.00% <ø> (ø)`
pyprep/find_noisy_channels.py	`100.00% <100.00%> (ø)`
pyprep/ransac.py	`97.85% <100.00%> (ø)`
pyprep/removeTrend.py	`95.08% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a91d31...0046dff. Read the comment docs.

mscheltienne commented 2 years ago

Done

sappelhoff commented 2 years ago

Thanks @mscheltienne

sappelhoff / pyprep

MRG: Add mne logger #112

Codecov Report