search

sappelhoff / pyprep

A Python implementation of the Preprocessing Pipeline (PREP) for EEG data
https://pyprep.readthedocs.io/en/latest/
MIT License
128 stars 30 forks source link

MNE-Python 1.0 fixes #114

Closed sappelhoff closed 2 years ago

sappelhoff commented 2 years ago

PR Description

intended to fix #113 eventually. First by adding some CI steps to catch such issues earlier in the future.

sappelhoff commented 2 years ago

@walkerped I test pyprep against mne-python 1.0 now (and also against new development versions to catch such future issues more quickly) ... however, the tests pass -- so it could be that we don't cover that critical part with our tests.

I pushed what I suspect to be a fix in https://github.com/sappelhoff/pyprep/pull/114/commits/e945797c273a119642df2727d14ab0ca15504464

could you try to re-install pyprep from this branch and see if it fixes your problem?

This should work:

pip uninstall pyprep
pip install git+https://github.com/sappelhoff/pyprep.git@fix/mne/1.0
codecov-commenter commented 2 years ago

Codecov Report

Merging #114 (798fb7b) into master (0f41361) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files           7        7           
  Lines         719      719           
=======================================
  Hits          712      712           
  Misses          7        7
Impacted Files Coverage Δ
pyprep/prep_pipeline.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f41361...798fb7b. Read the comment docs.