search

sappelhoff / pyprep

A Python implementation of the Preprocessing Pipeline (PREP) for EEG data
https://pyprep.readthedocs.io/en/latest/
MIT License
128 stars 30 forks source link

Possible to add an argument in find_bad_by_nan_flat() to change FLAT_THRESHOLD ? #142

Closed nabilalibou closed 5 months ago

nabilalibou commented 5 months ago

Hello, Kudo for this amazing package, I love reproducibility and automatisation when processing data. I observed that some nearly flat channels are not flagged neither by_deviation nor by_nan_flat (something that could be resolved by https://github.com/sappelhoff/pyprep/issues/83 ?).

Do you think an argument to toy with in find_bad_by_nan_flat() to change FLAT_THRESHOLD would be interesting ?

sappelhoff commented 5 months ago

Hi!

Do you think an argument to toy with in find_bad_by_nan_flat() to change FLAT_THRESHOLD would be interesting ?

Sure, that looks like something that could be easily added! Do you want to prepare a pull request for it? Else, I can look into it -- let me know.

solving:

would require much more thought and experimentation, I am afraid

nabilalibou commented 5 months ago

ok i'll do a PR, i think it will do more or less the trick before #83 is resolved