search

sappelhoff / pyprep

A Python implementation of the Preprocessing Pipeline (PREP) for EEG data
https://pyprep.readthedocs.io/en/latest/
MIT License
128 stars 30 forks source link

ADD flat_threshold argument in find_bad_by_nan_flat method from NoisyChannels #144

Closed nabilalibou closed 5 months ago

nabilalibou commented 5 months ago
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9999839) 98.89% compared to head (ff7f077) 98.89%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #144 +/- ## ========================================== - Coverage 98.89% 98.89% -0.01% ========================================== Files 7 7 Lines 726 725 -1 ========================================== - Hits 718 717 -1 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nabilalibou commented 5 months ago

Done

sappelhoff commented 5 months ago

wonderful, thanks a lot for your first contribution @nabilalibou!

Here a short note for you for the general pull request process that may help you down the line: https://hynek.me/articles/pull-requests-branch/

sappelhoff commented 5 months ago

just another note @nabilalibou if you have an ORCID account, may you please let me know your ID? And if you don't have an account (yet), I recommend that you get one, it'll always come in handy in a scientific career.

nabilalibou commented 5 months ago

Here a short note for you for the general pull request process that may help you down the line: https://hynek.me/articles/pull-requests-branch/

Thanks for the tips !

just another note @nabilalibou if you have an ORCID account, may you please let me know your ID? And if you don't have an account (yet), I recommend that you get one, it'll always come in handy in a scientific career.

I'm not necessarily aiming for a scientific career but you never know so here's my freshly created orcid: https://orcid.org/0009-0009-5869-9735 (should i add it myself in a future PR ?)

sappelhoff commented 5 months ago

Great, please add it in a new PR! 🎉 makes it easier for other people to find your work :-)