search

sappelhoff / pyprep

A Python implementation of the Preprocessing Pipeline (PREP) for EEG data
https://pyprep.readthedocs.io/en/latest/
MIT License
128 stars 30 forks source link

Fixes for Numpy 2 #148

Open sappelhoff opened 1 month ago

sappelhoff commented 1 month ago
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.89%. Comparing base (e4840d9) to head (e46a4fb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #148 +/- ## ======================================= Coverage 98.89% 98.89% ======================================= Files 7 7 Lines 725 725 ======================================= Hits 717 717 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sappelhoff commented 1 month ago

One of the issues is here: it seems that the RNG does change the seed for some reason:

https://github.com/sappelhoff/pyprep/blob/e4840d9c31ccd880e427448edd8317ff9f6f7909/tests/test_find_noisy_channels.py#L249-L254

cc @a-hurst

sappelhoff commented 1 week ago

with the most recent push, it turns out that the CI fails on all operating systems, so at least it's not something MacOS specific, after all.