feat!: improve `flatten: false` and rename to `structured: true`

sapphi-red / vite-plugin-static-copy

rollup-plugin-copy with dev server support.

MIT License

299 stars 32 forks source link

feat!: improve `flatten: false` and rename to `structured: true` #57

Closed brunoimbrizi closed 1 year ago

brunoimbrizi commented 1 year ago

(Re-submitting after the git history snafu on #47)

This PR addresses #46

remove ../ from dir so dest reliably replaces the first folder in the path on .split('/')[0]
trim slashes from the path so destDir doesn't end up in the root folder
update test 'glob with dir': dest should be expected to contain dir when flatten: false

sapphi-red commented 1 year ago

Would you add these commits by cherry-pick? https://github.com/sapphi-red/vite-plugin-static-copy/commit/82e69bd7f35cf224a24dc55fdf48a99511f4f715 https://github.com/sapphi-red/vite-plugin-static-copy/commit/3544728f42e659e76216894111f13c36552668e5

brunoimbrizi commented 1 year ago

Would you add these commits by cherry-pick? 82e69bd 3544728

Were those commits made to a protected branch? I don't think I have access to them. When opening the links on github I get the following warning:

⚠ This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

That's after doing:

$ git remote add sapphi-red https://github.com/sapphi-red/vite-plugin-static-copy.git
$ git fetch --all
$ git cherry-pick 82e69bd

fatal: bad revision '82e69bd'

sapphi-red commented 1 year ago

Probably running git apply with these patches will work. https://github.com/sapphi-red/vite-plugin-static-copy/commit/3544728f42e659e76216894111f13c36552668e5.patch https://github.com/sapphi-red/vite-plugin-static-copy/commit/82e69bd7f35cf224a24dc55fdf48a99511f4f715.patch

brunoimbrizi commented 1 year ago

Probably running git apply with these patches will work. https://github.com/sapphi-red/vite-plugin-static-copy/commit/3544728f42e659e76216894111f13c36552668e5.patch https://github.com/sapphi-red/vite-plugin-static-copy/commit/82e69bd7f35cf224a24dc55fdf48a99511f4f715.patch

Sorry, it didn't work.

$ git apply 3544728f42e659e76216894111f13c36552668e5.patch

error: patch failed: test/fixtures/vite.noflatten.config.ts:29
error: test/fixtures/vite.noflatten.config.ts: patch does not apply
error: patch failed: test/testcases.ts:158
error: test/testcases.ts: patch does not apply

It's my fault for getting rid of pr/47. Would you be okay with me copying the changes and recreating the commits in this PR?

sapphi-red commented 1 year ago

I'm fine with that 👍

sapphi-red commented 1 year ago

@brunoimbrizi I have released this as v0.16.0!