search

sapphiredev / utilities

Common JavaScript utilities for your TypeScript projects
https://www.sapphirejs.dev/
MIT License
157 stars 39 forks source link

refactor(utilities): rename `baseVariants` to `toTitleCaseDiscordJsVariants` #754

Closed favna closed 5 months ago

favna commented 6 months ago

This constant is exported after #750 but the name was kind of vague

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.79%. Comparing base (56b377f) to head (2bc798e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #754 +/- ## ======================================= Coverage 55.79% 55.79% ======================================= Files 232 232 Lines 18546 18546 Branches 1299 1299 ======================================= Hits 10348 10348 Misses 8193 8193 Partials 5 5 ``` | [Flag](https://app.codecov.io/gh/sapphiredev/utilities/pull/754/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | Coverage Δ | | |---|---|---| | [18](https://app.codecov.io/gh/sapphiredev/utilities/pull/754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | `55.79% <100.00%> (ø)` | | | [19](https://app.codecov.io/gh/sapphiredev/utilities/pull/754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | `55.79% <100.00%> (ø)` | | | [20](https://app.codecov.io/gh/sapphiredev/utilities/pull/754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | `55.79% <100.00%> (ø)` | | | [21](https://app.codecov.io/gh/sapphiredev/utilities/pull/754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | `55.79% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Nytelife26 commented 6 months ago

all of these except the name change of baseVariants will be resolved by #750 anyway, so i would recommend rescoping this to just the name change. other than that, world's easiest lgtm