search

sapphiredev / utilities

Common JavaScript utilities for Sapphire Projects
https://www.sapphirejs.dev/
MIT License
153 stars 39 forks source link

feat(utilities): expose `Arr` to the docs #780

Closed favna closed 2 months ago

favna commented 2 months ago

Fixes this warning:

[warning] Arr, defined in ./projects/utilities/packages/utilities/src/lib/types.ts, is referenced by AbstractCtor.A but not included in the documentation

favna commented 2 months ago

Considering the type was already exported on a TS level I think that would be a breaking change. Thoughts @vladfrangu ?

vladfrangu commented 2 months ago

Considering the type was already exported on a TS level I think that would be a breaking change. Thoughts @vladfrangu ?

if its a private type, i'd be willing to accept it as sem minor

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.48%. Comparing base (7c2bed2) to head (93e30a0). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #780 +/- ## ========================================== + Coverage 61.71% 62.48% +0.76% ========================================== Files 297 307 +10 Lines 8312 8481 +169 Branches 917 1536 +619 ========================================== + Hits 5130 5299 +169 Misses 3177 3177 Partials 5 5 ``` | [Flag](https://app.codecov.io/gh/sapphiredev/utilities/pull/780/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | Coverage Δ | | |---|---|---| | [18](https://app.codecov.io/gh/sapphiredev/utilities/pull/780/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | `62.48% <ø> (+0.76%)` | :arrow_up: | | [19](https://app.codecov.io/gh/sapphiredev/utilities/pull/780/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | `62.48% <ø> (+0.76%)` | :arrow_up: | | [20](https://app.codecov.io/gh/sapphiredev/utilities/pull/780/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | `62.48% <ø> (+0.76%)` | :arrow_up: | | [21](https://app.codecov.io/gh/sapphiredev/utilities/pull/780/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev) | `62.48% <ø> (+0.76%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sapphiredev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.