sapphiredev / utilities

Common JavaScript utilities for your TypeScript projects
https://www.sapphirejs.dev/
MIT License
157 stars 39 forks source link

refactor(discord-utilities): switch to jdecked twemoji fork #797

Closed SerenModz21 closed 2 months ago

SerenModz21 commented 2 months ago

Discord has switched to using Justine De Caires' (jdecked) Twemoji fork. Justine is an ex-Twitter employee who off the top of my head, used to work on Twemoji but got laid off during the layoffs after Elon bought Twitter/X. Therefore, switching Sapphire's regex to using said fork would be better suited.

Benefits of this change:

Sources:

SerenModz21 commented 2 months ago

Thank you for your review Vlad! The script was the first thing that I changed and ran it afterwards to update the actual code, since it gets overridden anyway.

https://github.com/sapphiredev/utilities/pull/797/files/8f4b64fe0bbd4194159acc88f0889f6141ce32e2#diff-ea04fd7ec7f44a64238cca194037a694d90415d43bb2f5a871379f49544fd852