saprykin / plibsys

Highly portable C system library: threads and synchronization primitives, sockets (TCP, UDP, SCTP), IPv4 and IPv6, IPC, hash functions (MD5, SHA-1, SHA-2, SHA-3, GOST), binary trees (RB, AVL) and more. Native code performance.
MIT License
672 stars 74 forks source link

Vms x86 #108

Closed whcox603 closed 1 month ago

whcox603 commented 1 month ago

I did this port of the library to vms_x86 about 6 months ago. Not many changes. I did rewrite the vms_build procedure. I held off requesting a merge to await a fix for the 3 failing tests. I commented in a group somewhere and got a reply from a developer that sounded like it would be fixed in the next release, but I was not able to confirm the fix. I also noted that the one new test failure was due to C and C++ disagreeing on sizes.

My VMS_x86 license expired a month ago and I am still awaiting a new license.

Feel free to reject this if you have already done the port.

bill

saprykin commented 1 month ago

Hi Bill,

Thanks for PR. I'm actually working on VMS x86 port in the last days :) Looking into the long size issue right now, the rest was quite trivial. I did not do much changes in build_vms.com, though, maybe a few lines. I suggest that I merge my changes into your PR, as most of them are common. I have only access to Alpha and x86 in emulators, cannot test on IA64.

Did IEEE floating denormalisation cause any issues on x86?

whcox603 commented 1 month ago

Alexander,

The only test issues I had were the 3 that were already failing, plus the one caused by the size mismatch.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

whcox603 commented 1 month ago

Do the 3 tests still fail on vms?

bill

On Wed, May 15, 2024 at 7:22 PM Alexander Saprykin @.***> wrote:

Merged #108 https://github.com/saprykin/plibsys/pull/108 into master.

— Reply to this email directly, view it on GitHub https://github.com/saprykin/plibsys/pull/108#event-12824811710, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNZYPCWMRV3Y46NKBZZDZDZCPUZRAVCNFSM6AAAAABHYUMMDWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHAZDIOBRGE3TCMA . You are receiving this because you authored the thread.Message ID: @.***>

saprykin commented 1 month ago

Do the 3 tests still fail on vms?

Yes. The only difference is that semaphore test passes one time when compiled with 32-bit pointers. Each next time it fails.