search

saqimtiaz / BibSearch

App for Realfagsbibilioteket at UiO
MIT License
2 stars 3 forks source link

Clicking on magnifying glass in top right causes app to hang forever on Iphone #36

Closed kyrretl closed 11 years ago

kyrretl commented 11 years ago

Should access map? Anyway clicking the icon makes the app hang and the process must be killed and app restarted to resume usage

danmichaelo commented 11 years ago

More or less the same on Android, but at least you don't have to kill the app there – I got back pressing the back button twice :P

saqimtiaz commented 11 years ago

The error is that it should read BookWorms.showSearchResults and not showSearchResults on line 232 in bibsearch.js

Fixed in last commit, get the updated apk here: https://github.com/saqimtiaz/BibSearch/blob/master/Realfagsbibilioteket%20-%20UiO/bin/Realfagsbibilioteket%20-%20UiO.apk?raw=true

iphone version will need to be updated.

danmichaelo commented 11 years ago

I tried just that first ;) Btw. I'm not sure if it's intended that the search should reset or not, but I think it's better if one get back to the last search results.

saqimtiaz commented 11 years ago

This was tested with users and their expectation was to use the back button to get back to the last search results, and get a fresh search screen when using the search button.

danmichaelo commented 11 years ago

Silly users :D

But more to the point; that works fine on Android, but on iPhone I understand there isn't a system-wide back-button? And clicking the "UiO"-button I get straight back to the start page.. perhaps that should point back to the search results?

saqimtiaz commented 11 years ago

Can you confirm that clicking the UiO button on an iphone takes you to the home page and not the previous page?

The behaviour on Android and web is supposed to be "home", but on iphone it should be "back". If it goes home then this is a bug and please create an issue for it.

(the conditional behaviour was added here: https://github.com/saqimtiaz/BibSearch/commit/73dcfaede0cdc5df5e61cdeaa56c829306b57ff6 )

danmichaelo commented 11 years ago

Aha! Nope, I just didn't imagine that the button could behave differently on Android and iPhone. Not sure if that is a good design pattern though, quite confusing when working with both Android and iPhone. Personally, I would prefer the button to behave the same way on both systems, even if it would be slightly "less efficient" in turn of the number of key presses to get back. But this might be something you've discussed as well.