search

saqimtiaz / BibSearch

App for Realfagsbibilioteket at UiO
MIT License
2 stars 3 forks source link

Book shelf location should show on map #37

Open kyrretl opened 11 years ago

kyrretl commented 11 years ago

When you click on the map to get fullscreen, the book shelf location should show. This is because users navigate by the map, but forget the book shelf location and then they have to exit the map to get the location again. A bit user-unfriendly.

As a suggestion: there could be a fixed div on the (vertical) top of the map always showing the shelf location so that it will be visible even if you scroll.

saqimtiaz commented 11 years ago

The problem with a fixed div is that it will overlay the map and possibly the part of the map that the user wants to see.

danmichaelo commented 11 years ago

Not sure if I get the problem. As long as the map has a top margin the same height as the "header" div, the entire map is still accessible. Yes, you loose a little bit of screen space, meaning you may have to scroll a little bit more, but the handiness of having the shelf location available when you are looking for the book should make up for that?

(I would suggest also adding the close button to this div.)

saqimtiaz commented 11 years ago

Kyrre's suggestion was that the div should scroll with the page, hence my earlier comment.

kyrretl commented 11 years ago

On 29.05.2013 16:35, saqimtiaz wrote:

Kyrre's suggestion was that the div should scroll with the page, hence my earlier comment.

— Reply to this email directly or view it on GitHub https://github.com/saqimtiaz/BibSearch/issues/37#issuecomment-18620445.

Yes, it is a bit more complicated than what I first thought, since if the book happens to be underneath the div, it will not show. I had a talk with Dan Michael and we may use the coordinates from the server to fix something later, but it does not need to be prioritized now!

Other things are more important before the release date. Infact this issue can be something me and Dan Michael and Fredrik can have as a goal to fix later in the semester (as an exercise to get to know the code).

Kyrre