sara-nl / irods-msi-persistent-id

iRODS microservices for managing EPIC PIDs
Other
0 stars 0 forks source link

spec file has extra unneeded characters #1

Closed cookie33 closed 5 years ago

cookie33 commented 5 years ago

The spec file has:

%if "%{irodsversion}" == "4.1.11"
%define irods_msi_path /var/lib/irods/plugins/microservices/
%else
%define irods_msi_path /usr/lib/irods/plugins/microservices/
%endif

I would remove the "/" at the end of the lines and make it:

%if "%{irodsversion}" == "4.1.11"
%define irods_msi_path /var/lib/irods/plugins/microservices
%else
%define irods_msi_path /usr/lib/irods/plugins/microservices
%endif

This because the "/" are used in the specific itself.

stefan-wolfsheimer commented 5 years ago

@cookie33 I have fixed this. I wonder if it actually matters. The double slashes are used in paths which are normalized anyways. Do you know an example / case were this is crucial ?