New user notice - Githubissues

sara-sabr / auto-evaluation-devops-self-assessment

Auto-évaluation DevOps Self Assessment

https://sara-sabr.github.io/auto-evaluation-devops-self-assessment/

MIT License

3 stars 3 forks source link

New user notice #64

Closed gcharest closed 3 years ago

gcharest commented 3 years ago

PR to address user feedback:

[x] First time users are welcomed with a modal (layered window with text)
[x] Modal contains details about the tool and how the data is saved anonymously on very specific conditions
[x] Proper text and examples of anonymous data
[x] Checkbox for user to not display the modal on next visit if they do not wish so.
[x] Button to manually trigger the modal for users who have selected to not be prompted again

gcharest commented 3 years ago

One thing to consider is that the checkbox probably should be updated with current value of the store.

Scenario:	Action	Stored value of `displayWelcomeNotice`
User loads app for the first time.	true
User checks "Do not show again" and clicks on OK	false
User clicks on "Display welcome message" button	true

At this point, value should stay false (which is not the case since the initial state of the modal indicates that the unchecked value is set to true. That's where the modal value should be updated based on the store's state rather than hard coded.

gcharest commented 3 years ago

Nice job with creating a user note. I find it much better than having a tool intro in the footer. Can't wait to test it! Just a small typo in the header with DevOps in "Welcome to the Devops Self-Assessment Tool!" And are we still changing the content?

Fixed in last commit d4a6656