saraabdelsalam / Algoriza-Internship-2023BE35

1 stars 0 forks source link

recreating domain models & adding DbSets #5

Closed saraabdelsalam closed 11 months ago

saraabdelsalam commented 11 months ago

i have created the first 2 tasks but when i try to add migration it fails saying couldn't load assembly and i couldn't figure out how to fix this error

saraabdelsalam commented 11 months ago

i have created the migration for the schema successfully, added access modifiers for the dbsets & removed the Unused package in the infrastructure layer in the last commit

YoussefWaelMohamedLotfy commented 11 months ago

@saraabdelsalam Is the Schema Checked for Correctness? If yes, then we can proceed with the next task.

Also, review my commit for the changes regarding indentation and spacing. I would like that you follow the same approach for more readable files and unified coding standards (for the future and those will edit after you)

Highlights:

saraabdelsalam commented 11 months ago

@YoussefWaelMohamedLotfy i have a question to make sure the schema is right 100%, i have made class doctor inheritance from application user and in the migration schema the doctors table is renamed to AspNetUsers with all of the properties related to application user class and doctor class , so i wonder is this correct or there's a problem and doctors should appear as a separated table

YoussefWaelMohamedLotfy commented 11 months ago

@YoussefWaelMohamedLotfy i have a question to make sure the schema is right 100%, i have made class doctor inheritance from application user and in the migration schema the doctors table is renamed to AspNetUsers with all of the properties related to application user class and doctor class , so i wonder is this correct or there's a problem and doctors should appear as a separated table

Refer to this doc about EF Inheritance Strategies & this one about Inheritance Stategies benchmarks and let's discuss what did you understand and what would be your decision.

YoussefWaelMohamedLotfy commented 11 months ago

@saraabdelsalam Don't forget to resolve code comments above once it's done