refactoring first controller to minimal api - Githubissues

saraabdelsalam / Algoriza-Internship-2023BE35

1 stars 0 forks source link

refactoring first controller to minimal api #7

Closed saraabdelsalam closed 9 months ago

saraabdelsalam commented 9 months ago

i have started to refactor Api layer, but i want to make sure if i'm using minimal Apis correclty 100% or ther's something i should edit before adding other commits similar to this way for the rest of end points

YoussefWaelMohamedLotfy commented 9 months ago

@saraabdelsalam You are correct about your initial setup for an endpoint. However, a few comments I would like to say:

Your endpoints were not shown on Swagger UI. It is important that all endpoints are detected & registered on the Swagger UI. This was because you did not return a status code from your endpoints.
You should be grouping all endpoints related to each other for unifing API config per group

Check the last commit for clarification, and you may continue to add there rest of endpoints for the remaining containers, except ApplicationUser