sarafridov / K-Planes

Other
486 stars 46 forks source link

Blender evaluation split #11

Closed hturki closed 1 year ago

hturki commented 1 year ago

Thanks for the great work! When running this code on the blender dataset I get metrics that line up with the paper. However, looking at https://github.com/sarafridov/K-Planes/blob/main/plenoxels/datasets/synthetic_nerf_dataset.py#L36, I think that we're both training and testing against the "test" split vs training on the train split and then evaluating on the held out test set. Is this intentional or am I misunderstanding what's going on?

sarafridov commented 1 year ago

Good catch! This looks like a bug for that dataset loader; fixing it now (and will update the results tables). Thanks for bringing it to my attention.

sarafridov commented 1 year ago

All fixed now! (updated arxiv will come out tomorrow, and CVPR cameraready is also fixed). Thanks again for pointing this out.