sarafridov / K-Planes

Other
479 stars 45 forks source link

Mismatch in total variation loss between description in paper and the implementation #28

Closed NagabhushanSN95 closed 1 year ago

NagabhushanSN95 commented 1 year ago

Hi, Thanks for open-sourcing the code for your work.

In the paper, you have mentioned that total variation in space is encouraged in "1D along spatial dimensions in the space-time planes" and "2D along both spatial dimensions in the space-space planes". However, in the code, total variation loss is applied along 2 dimensions for all the planes including space-time planes. Further, the total variation loss is applied identically twice for the space-space planes. Can you please clarify why?

Giodiro commented 1 year ago

Hi! Yes there's a few small bugs in the regularization code. They're fixed in a regfix branch in this repository, but the regularization coefficients have not been updated yet. I'm working on it right now! The kplanes_nerfstudio code has the updated code + configs already.

NagabhushanSN95 commented 1 year ago

Okay. Thank you!