sarafridov / K-Planes

Other
486 stars 46 forks source link

Bug in depth rendering? #46

Open nikola3794 opened 7 months ago

nikola3794 commented 7 months ago

I think that there is a bug in the current depth rendering: https://github.com/sarafridov/K-Planes/blob/7e3a82dbdda31eddbe2a160bc9ef89e734d9fc54/plenoxels/models/lowrank_model.py#L159-L160

I believe it should actually be:

one_minus_transmittance = torch.sum(weights, dim=-2).clamp(min=1e-6)
depth = torch.sum(weights * steps, dim=-2)/one_minus_transmittance