search

sarah-ek / faer-rs

Linear algebra foundation for the Rust programming language
https://faer-rs.github.io
MIT License
1.82k stars 61 forks source link

extra convenience macros #100

Closed DeliciousHair closed 7 months ago

DeliciousHair commented 7 months ago

Address #99

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (00a664f) 85.11% compared to head (9a74c50) 85.14%. Report is 1 commits behind head on main.

Files Patch % Lines
faer-libs/faer-core/src/lib.rs 98.61% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #100 +/- ## ========================================== + Coverage 85.11% 85.14% +0.02% ========================================== Files 68 68 Lines 87236 87394 +158 ========================================== + Hits 74255 74415 +160 + Misses 12981 12979 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sarah-ek commented 7 months ago

looks good to me! just one remark: unlike mat!, there's no ambiguity when the number of elements in a row or column is zero. in that case we can replace the compile error by $crate::Col::new().

DeliciousHair commented 7 months ago

looks good to me! just one remark: unlike mat!, there's no ambiguity when the number of elements in a row or column is zero. in that case we can replace the compile error by $crate::Col::new().

Good point, fixed!