sarah-ek / faer-rs

Linear algebra foundation for the Rust programming language
https://faer-rs.github.io
MIT License
1.75k stars 56 forks source link

fix documentation for subrows() and subrows_mut() #113

Closed bernhard-musch closed 4 months ago

bernhard-musch commented 4 months ago

Looks like a copy-and-paste error in the documentation. Current documentation says these (not-unsafe) functions exhibit undefined behavior. However the code appears to panic.

sarah-ek commented 4 months ago

oh, whoops. yeah a copy and paste error. thanks for finding it

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.24%. Comparing base (4ef7367) to head (c4635e8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #113 +/- ## ========================================== - Coverage 86.24% 86.24% -0.01% ========================================== Files 118 118 Lines 87802 87802 ========================================== - Hits 75724 75722 -2 - Misses 12078 12080 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.