search

sarah-ek / faer-rs

Linear algebra foundation for the Rust programming language
https://faer-rs.github.io
MIT License
1.82k stars 61 forks source link

faer 0.17 doesn't compile when default features are disabled #116

Closed cospectrum closed 1 month ago

cospectrum commented 6 months ago

Describe the bug default-features = false leads to a compilation error.

Consider using cargo yank. Also think about a better CI, using cargo workspace and cargo hack can help

To Reproduce

cargo new reproduce && cd reproduce && cargo add faer-core --no-default-features && cargo check

Expected behavior successful compilation

Desktop (please complete the following information):

sarah-ek commented 6 months ago

faer-core is no longer maintained separately. as of v0.18 everything is packaged in the top level faer crate.

cospectrum commented 6 months ago

faer@0.17 ----no-default-features also doesn't compile. 0.18 seems ok

sarah-ek commented 6 months ago

I'll add a minimal no_std project to the ci to avoid this happening again

sarah-ek commented 1 month ago

closing this since no_std tests were added a while ago