search

sarah-ek / faer-rs

Linear algebra foundation for the Rust programming language
https://faer-rs.github.io
MIT License
1.82k stars 61 forks source link

Change `div_ceil` to `msrv_div_ceil` #121

Closed kenken-neko closed 6 months ago

kenken-neko commented 6 months ago

Change

It has been modified to use msrv_div_ceil, which is implemented in the utils of this repository, instead of the div_ceil.

Reason

The div_ceil is unstable, which causes build errors such as the one in the image sent. To avoid this error. divceil

Supplement

I have also confirmed that all tests of cargo test are completed without any problems.

kenken-neko commented 6 months ago

Thank you for a very nice and beneficial implementation. I would appreciate it if you could review this PR when you have time.

sarah-ek commented 6 months ago

lgtm!