Closed DeliciousHair closed 7 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
00a664f
) 85.11% compared to head (9a74c50
) 85.14%. Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
faer-libs/faer-core/src/lib.rs | 98.61% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
looks good to me! just one remark: unlike mat!
, there's no ambiguity when the number of elements in a row or column is zero. in that case we can replace the compile error by $crate::Col::new()
.
looks good to me! just one remark: unlike
mat!
, there's no ambiguity when the number of elements in a row or column is zero. in that case we can replace the compile error by$crate::Col::new()
.
Good point, fixed!
Address #99