Closed DJDuque closed 1 year ago
the implementation looks good to me. if the CI runs successfully then i'll be merging this. (it's fine if it complains about code coverage. it does that sometimes)
Patch coverage: 100.00
% and project coverage change: +0.48
:tada:
Comparison is base (
000506c
) 92.18% compared to head (eeb7005
) 92.67%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Same as PR https://github.com/sarah-ek/faer-rs/pull/48, I am not sure if this is the correct way of implementing these traits. Nonetheless, I have been playing around with
faer
a lot lately, and having these traits has helped me to prototype and test stuff easily.If this (or PR https://github.com/sarah-ek/faer-rs/pull/48) is something that you don't want in
faer-core
it is OK to close this as "wont fix".