I was skimming through the high level API PR, and saw renaming of set_constant to fill_with_constant. It's really a minor thing, but how about naming this method just fill as analogous to slice::fill? As for fill_with_zero, it does not have a counterpart in std (or I am now aware of it), but fill_zero sounds fine to me. This way, you can leave fill_with name for the method taking a filling closure, as is also a convention in std (slice::fill_with).
I was skimming through the high level API PR, and saw renaming of
set_constant
tofill_with_constant
. It's really a minor thing, but how about naming this method justfill
as analogous to slice::fill? As forfill_with_zero
, it does not have a counterpart in std (or I am now aware of it), butfill_zero
sounds fine to me. This way, you can leavefill_with
name for the method taking a filling closure, as is also a convention in std (slice::fill_with).