sarah-quinones / faer-rs

Linear algebra foundation for the Rust programming language
https://faer-rs.github.io
MIT License
1.82k stars 61 forks source link

Rename fill_with_constant to fill? #64

Closed pnevyk closed 1 year ago

pnevyk commented 1 year ago

I was skimming through the high level API PR, and saw renaming of set_constant to fill_with_constant. It's really a minor thing, but how about naming this method just fill as analogous to slice::fill? As for fill_with_zero, it does not have a counterpart in std (or I am now aware of it), but fill_zero sounds fine to me. This way, you can leave fill_with name for the method taking a filling closure, as is also a convention in std (slice::fill_with).

sarah-quinones commented 1 year ago

sounds like a good idea if it's to be consistent with the standard library. i'll have it changed by the next release unless i forget :smile:

sarah-quinones commented 1 year ago

done!