sarah-quinones / gemm

MIT License
76 stars 11 forks source link

Add GemmType trait for dispatching gemm fn calls #22

Open ivarflakstad opened 12 months ago

ivarflakstad commented 12 months ago

I was wondering if this change would be of interest. Removes the if-else-panic and let's the type system take care of that constraint instead.

sarah-quinones commented 12 months ago

thanks for the PR! though im not really sure if i want this. having no bounds is useful for usage in generic libraries, which is where the library is meant to be used. i'd prefer to leave it up to the consumers of the library to implement such a wrapper

ivarflakstad commented 12 months ago

Hmm I see, that's a valid point. Still I want to emphasize that it is the exact same "bounds" as were there originally - except it was expressed through if statements.

So the only change I can see is that it will fail to build rather than panic at runtime.