search

sarah-quinones / gemm

MIT License
76 stars 11 forks source link

Regarding Panic Comment in gemm.rs #5

Open mert-kurttutan opened 1 year ago

mert-kurttutan commented 1 year ago

There is a comment in the code base: https://github.com/sarah-ek/gemm/blob/main/gemm/src/gemm.rs#L151

which says that gemm panics if T is not f32 and f64. But I was able to run it with f16 type as well.

I guess this is a typo since the function is also used by gemm_dispatch function to matmul on f16 data type ??

sarah-quinones commented 1 year ago

yeah, the comment there is outdated. thanks for pointing it out