search

sarah-quinones / gemm

MIT License
76 stars 11 forks source link

`const` misused as `static` #7

Closed cbeuw closed 1 year ago

cbeuw commented 1 year ago

These global flags need to be static, not const. const is effectively copy+paste of the RHS, so you can't store anything at runtime.

https://github.com/sarah-ek/gemm/blob/2283886ff43f9ad2e856e595249ff90ad4912582/gemm-common/src/gemm.rs#L105-L110

sarah-quinones commented 1 year ago

oh, thanks for noticing that. i'll fix it asap

sarah-quinones commented 1 year ago

fixed by commit 977bbc5