sarah-quinones / pulp

MIT License
207 stars 10 forks source link

pulp::simd_type! generates a missing import error #10

Closed IceTDrinker closed 6 days ago

IceTDrinker commented 6 days ago

I'm guessing the macro uses MaybeUninit directly instead of a fully qualified path like std::mem::MaybeUninit or core::mem::MaybeUninit

Fix is straightforward on our end but could be nice for people who use this macro in the wild :)

error[E0412]: cannot find type `MaybeUninit` in this scope
   --> tfhe-ntt/src/lib.rs:135:1
    |
135 | / pulp::simd_type! {
136 | |     struct V4IFma {
137 | |         pub sse: "sse",
138 | |         pub sse2: "sse2",
...   |
157 | |     }
158 | | }
    | |_^ not found in this scope
    |
    = note: this error originates in the macro `pulp::simd_type` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing this union
    |
78  + use std::mem::MaybeUninit;
    |
sarah-quinones commented 6 days ago

thanks. gonna fix it soon, nice to see you again btw 😄

IceTDrinker commented 6 days ago

thanks. gonna fix it soon, nice to see you again btw 😄

Likewise 😄 👋

sarah-quinones commented 6 days ago

btw, if you send me a DM on discord, i have some multithreading optimizations you might be interested in chatting about

IceTDrinker commented 6 days ago

btw, if you send me a DM on discord, i have some multithreading optimizations you might be interested in chatting about

definitely ! Same handle :)

IceTDrinker commented 6 days ago

I meant, I don't think I have your handle but mine's the same

sarah-quinones commented 6 days ago

fixed