search

sarah-walker-pcem / arculator

Arculator
http://b-em.bbcmicro.com/arculator
GNU General Public License v2.0
56 stars 23 forks source link

SDL2 Audio subsystem must be initialised before being used #32

Closed sjnewbury closed 1 year ago

sjnewbury commented 1 year ago

Also report SDL error message on failure.

Fixes problem with no sound I reported in issue https://github.com/sarah-walker-pcem/arculator/issues/30

Sophira commented 1 year ago

Sorry for the delay in responding here - life has been weird lately.

Although this change compiles and "works" (well, for me it does nothing since sound was already working for me), I would be wary of it because we don't exactly know why the initialisation isn't working for you when it is for me - especially so since we're using the same Linux distro! In particular, it's clear that for me the audio subsystem must already be getting initialised, otherwise sound wouldn't work for me either, so the commit description is inaccurate.

Of course, it's up to Sarah, but I'd recommend we take this back to #30 and try to troubleshoot this a bit more - it's possible we may be able to find out why it's not initialising and work on that. It may be that a fix like this is needed, but at the moment it feels like this is kind of a shot in the dark when we don't know why it's not initialising for you when it should be.