search

sarah-walker-pcem / arculator

Arculator
http://b-em.bbcmicro.com/arculator
GNU General Public License v2.0
56 stars 23 forks source link

build: Fix typo to allow wx-resources creation #42

Closed Sophira closed 10 months ago

Sophira commented 10 months ago

A typo in the Makefile meant that it was impossible for the wx-resources.cc file to be recreated during compile; this fixes that and removes the file from the distribution.

While it doesn't fix any particular issue on GitHub (though I did stumble upon it in the process of working on other issues), it should make it much easier to change the resources file in the future.

Sophira commented 10 months ago

Hold this commit - this seems to cause Arculator to fail with a segfault on my Linux machine when running a machine for some reason. I'll try to figure out what's wrong.

Sophira commented 10 months ago

So it turned out that because of this issue where recompiling wx-resources.cc wasn't possible, the repository's version of wx-resources.cc was updated directly when the option to change the black level was added, and the source arculator.xrc file wasn't changed. Fortunately, a close-to-original version of the arculator.xrc file is stored in the compiled file, allowing us to extract the changes necessary to allow it to compile the correct version of the file dynamically, which fixes the segfault.

[edit: I made a mistake initially and used spaces instead of tabs, so I've force-pushed a version of the commit that correctly uses tabs instead.]