search

sarahsporck / Migration-Test-Repository

This repository is used to test the ticket migration from jira to github
0 stars 1 forks source link

IGAPP-758: Navigation to POI Detail causes rerender cycles #3424

Closed jira-to-github-migrator-test[bot] closed 1 year ago

jira-to-github-migrator-test[bot] commented 1 year ago

Andreas Fischer - 7.9.2021, 11:20:29

Expected Behavior

Navigating from POIS Overview to Details Page forces the navigation once with a new path (detail page) and renders the POIS Container once

Actual Behavior

Navigating from POIS Overview to Details Page forces navigation once setting the same path(Overview page = null) starts rerendering POIS Container and changing the path to DetailsPage and rerenders the POIS Container. This may happen several times. This leads to an increasing loading time

 

Steps to reproduce

  1. Set a console.log or a debugger in POISContainer
  2. Remove the "ShouldComponentUpdate" in POISContainer (optional only if IGAPP-743 was merged)
  3. Navigate to POIS Overview
  4. Navigate to Details Page and check console.log
  5. Check your logs

Some investigations have shown that the mapDisplayToProps get rerendered multiple times 

Environment: - Linked issues:

jira-to-github-migrator-test[bot] commented 1 year ago

sarahsporck - 19.11.2021, 10:38:33

Maybe checkout https://github.com/welldone-software/why-did-you-render

Steffen Kleinle - 26.1.2022, 14:07:53

The current workaround works fine and we don't want to spend even more time on this.