search

sarahtattersall / PIPE

PIPE - Platform Independent Petri Net Editor
MIT License
232 stars 73 forks source link

Problem with inhibitory arcs doesn't let user continue #21

Closed sjdayday closed 10 years ago

sjdayday commented 10 years ago

The dialog box for some error condition relating to inhibitory arcs continues to re-appear, making it impossible to fix whatever the underlying problem is. Seen in tag v4.3.2. screen shot 2014-02-10 at 9 53 05 am

sjdayday commented 10 years ago

I included the window where I invoked PIPE, as each time the Message box re-appears we see something written to stdout/err....might help figure out where we're going wrong.... Steve

sarahtattersall commented 10 years ago

What were you trying to do with the arc at the time? Since this is v4.3.2 I'll see if it's fixed in the develop branch.

sjdayday commented 10 years ago

darned if I can remember. I had added two inhibitor arcs previously, but in the meantime I clicked on some link somewhere I didn't mean to and might've set its attributes incorrectly. I think the key thing, though, is to figure out where this error message is being generated, and to give the user a chance to go back to the gui to fix the problem, rather than dropping back immediately into evaluating correctness. That's the real headache.

Steve

On Mon, Feb 10, 2014 at 1:24 PM, Sarah Tattersall notifications@github.comwrote:

What were you trying to do with the arc at the time? Since this is v4.3.2 I'll see if it's fixed in the develop branch.

Reply to this email directly or view it on GitHubhttps://github.com/sarahtattersall/PIPE/issues/21#issuecomment-34684085 .

Steve Doubleday UC Irvine Mathematical Behavioral Sciences stevedoubleday@gmail.com 818-648-8381

sarahtattersall commented 10 years ago

I've discovered (as you're aware by the message) that it's during the call to create either the forwards, backwards or inhibitor matrix. Where this gets called is a bit of a mystery in this version since the code's quite difficult to even understand. It could be due to animation, running a submodule, or something else I just don't know!

I largely consider the code in PIPE v4 a bit of a write off as it's not that well structured. Since I've re-written all this logic with the model approach and done away with an inhibitor matrix would you be ok with me closing this issue unless it appears in the upcoming BETA release?

sjdayday commented 10 years ago

sounds like a plan to me -- onwards and upwards :)

On Mon, Feb 10, 2014 at 1:54 PM, Sarah Tattersall notifications@github.comwrote:

I've discovered (as you're aware by the message) that it's during the call to create either the forwards, backwards or inhibitor matrix. Where this gets called is a bit of a mystery in this version since the code's quite difficult to even understand. It could be due to animation, running a submodule, or something else I just don't know!

I largely consider the code in PIPE v4 a bit of a write off as it's not that well structured. Since I've re-written all this logic with the model approach and done away with an inhibitor matrix would you be ok with me closing this issue unless it appears in the upcoming BETA release?

Reply to this email directly or view it on GitHubhttps://github.com/sarahtattersall/PIPE/issues/21#issuecomment-34687268 .

Steve Doubleday UC Irvine Mathematical Behavioral Sciences stevedoubleday@gmail.com 818-648-8381