sarahteonin / pe

0 stars 0 forks source link

Wrong error shown when trying to import consultation data #4

Open sarahteonin opened 2 weeks ago

sarahteonin commented 2 weeks ago

When trying to import the same file which was exported from the app, error shown is that 4 entries had errors even though the file was not edited. This can be problematic as users are unable to use the importconsult function, and may think there are errors in their entries when there are no errors.

Exported file successfully: Screenshot 2024-11-15 at 4.52.55 PM.png

File which was exported and imported: Screenshot 2024-11-15 at 4.53.19 PM.png

When trying to import same file: Error shown: Imported 0 consultations successfully. 4 entries had errors. Failed entries written to: data/error.csv Screenshot 2024-11-15 at 4.53.25 PM.png

nus-pe-script commented 1 week ago

Team's Response

This is intended. If you are trying to import an unedited file that just got exported, then all the consultations present in the file would be duplicates. Hence all of the entries would cause an "error".

The follows is as mentioned in the DeveloperGuide:

4a. Invalid data in rows

4a1. TAHub logs invalid entries to error.csv. 4a2. TAHub continues processing remaining rows. 4a3. Error types include: Invalid date/time format. Student not found in TAHub. Duplicate consultation. 4a4. Success message includes count of errors.

Use case ends.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]