saramibreak / DiscImageCreator

This is the disc (CD, GD, DVD, HD-DVD, BD, GC/Wii, XBOX, XBOX 360) and disk (Floppy, MO, USB etc) image creation tool
http://forum.redump.org/topic/10483/discimagecreator/
Apache License 2.0
530 stars 45 forks source link

Remove printing directory from .dat output file #178

Closed bismurphy closed 1 year ago

bismurphy commented 1 year ago

Currently when a disc is dumped, the .dat file that gets created alongside the dumped file will contain a game name and description field. These fields get filled in with the full working directory where DIC was invoked. This does not align with the fields, and additionally releases a user's file structure which, while not dangerous, is unnecessary personal data being shared which is unrelated to the disc being dumped.

This pull request simply changes the two lines in the code that had inserted those values, to instead insert strings matching the default.dat file. A better long-term solution would be if default.dat were modified to include the "insert name" and "insert description fields", so that all the code has to touch is the line containing the checksums, but for now simply patching out the segment of code which writes the user's directory into the file should be sufficient.