saramibreak / DiscImageCreator

This is the disc (CD, GD, DVD, HD-DVD, BD, GC/Wii, XBOX, XBOX 360) and disk (Floppy, MO, USB etc) image creation tool
http://forum.redump.org/topic/10483/discimagecreator/
Apache License 2.0
510 stars 45 forks source link

[BUG] Dumping with 20230401 does not produce checksums #189

Closed Whovian9369 closed 1 year ago

Whovian9369 commented 1 year ago

Version Version used is 20230401

Describe the bug No checksum is generated in output dat file. Note that the disc described below is only an example. I first noticed this issue using an audio cd.

Screenshots Command used: DiscImageCreator.exe dvd E "ISO\Final Fantasy XIV - Shadowbringers\U19001W_001_D01.iso" 16 /rr 10

Screenshot of console output: DiscImageCreator console output

Screenshot of U19001W_001_D01.dat: Screenshot of U19001W_001_D01.dat

Disc title Final Fantasy XIV Online - Shadowbringers (Japan) (ファイナルファンタジーXIV Online: 漆黒のヴィランズ)

Disc ringcode

Data Side Mastering Code (laser branded/etched): SE-G0072 A0   1
Data Side Mastering SID Code: IFPI L271
Data Side Mould SID Code: 45T0

URL The best place to find it would likely be Yahoo Auctions Japan. The cheapest one that I quickly found is ¥3,164.

Log file Click here to download the ZIP archive of the log files

saramibreak commented 1 year ago

Thanks report. Fixed it. DiscImageCreator_test.zip

Whovian9369 commented 1 year ago

I tested that version, and it is not completely fixed. It works with DVDs and single track CDs. Though when using both 20230401 and the DiscImageCreator_test.zip that you posted, it fails on multi-track CDs. I double checked that the dump itself is good, but DIC does not hash the dump properly.


Here is some example output for a multi-track Audio CD:

Command used: DiscImageCreator.exe cd D "ISO\Sounds-of-Eorzea-Testing\Audio CD.bin" 24 /c2 20

C:\Users\Whovian\Downloads\Games\Tools\DiscImageCreator\DiscImageCreator_test-2023_04_03>DiscImageCreator.exe cd D "ISO\Sounds-of-Eorzea-Testing\Audio CD.bin" 24 /c2 20
AppVersion
        32 bit, AnsiBuild, 20230403T205524
/c2 val2 was omitted. set [0]
C:\Users\Whovian\Downloads\Games\Tools\DiscImageCreator\DiscImageCreator_test-2023_04_03\ISO\Sounds-of-Eorzea-Testing\ doesn't exist, so create.
CurrentDirectory
        C:\Users\Whovian\Downloads\Games\Tools\DiscImageCreator\DiscImageCreator_test-2023_04_03
WorkingPath
         Argument: ISO\Sounds-of-Eorzea-Testing\Audio CD.bin
         FullPath: C:\Users\Whovian\Downloads\Games\Tools\DiscImageCreator\DiscImageCreator_test-2023_04_03\ISO\Sounds-of-Eorzea-Testing\Audio CD.bin
            Drive: C:
        Directory: \Users\Whovian\Downloads\Games\Tools\DiscImageCreator\DiscImageCreator_test-2023_04_03\ISO\Sounds-of-Eorzea-Testing\
         Filename: Audio CD
        Extension: .bin
StartTime: 2023-04-03T12:28:15-0400
Set the drive speed: 4233KB/sec
DiskSize of [C:\Users\Whovian\Downloads\Games\Tools\DiscImageCreator\DiscImageCreator_test-2023_04_03\ISO\Sounds-of-Eorzea-Testing]
        Total:   499445190656 bytes
         Used:   438072569856 bytes
        ---------------------------
        Space:    61372620800 bytes
         => There is enough disk space for dumping
This drive supports [OpCode: 0xd8, SubCode: 1]
This drive supports [OpCode: 0xd8, SubCode: 2]
This drive supports [OpCode: 0xd8, SubCode: 8]
Checking reading lead-out -> OK
Checking SubQ adr (Track)  6/ 6
Checking SubRtoW (Track)  6/ 6
Set OpCode: 0xd8, SubCode: 8(Raw)
Checking SubQ ctl (Track)  6/ 6
Creating .scm (LBA) 228763/228763
No C2 errors
Moving .scm to .img
Creating cue and ccd (Track)  6/ 6
Creating bin (Track)  6/ 6
Hashing: Audio CD.img
[F:OutputHash][L:214] GetLastError: 2, The system cannot find the file specified.

EndTime: 2023-04-03T12:32:39-0400
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE datafile PUBLIC "-//Logiqx//DTD ROM Management Datafile//EN" "http://www.logiqx.com/Dats/datafile.dtd">
<datafile>
  <header>
    <name>-insert name-</name>
    <description>-insert description-</description>
    <version>-insert version-</version>
    <date>-insert date-</date>
    <author>-insert author-</author>
    <homepage>-insert homepage-</homepage>
    <url>-insert url-</url>
  </header>
  <game name="Sounds-of-Eorzea-Testing">
    <category>Games</category>
    <description>Sounds-of-Eorzea-Testing</description>
  </game>
</datafile>
saramibreak commented 1 year ago

Some fixed. DiscImageCreator_test.zip

Whovian9369 commented 1 year ago

It's fixed for multi-track CDs now as well, so thank you!

...
Checking reading lead-out -> OK
Checking SubQ adr (Track)  6/ 6
Checking SubRtoW (Track)  6/ 6
Set OpCode: 0xd8, SubCode: 8(Raw)
Checking SubQ ctl (Track)  6/ 6
Creating .scm (LBA) 228763/228763
No C2 errors
Moving .scm to .img
Creating cue and ccd (Track)  6/ 6
Creating bin (Track)  6/ 6
Hashing: Audio CD.img
Hashing: Audio CD (Track 1).bin
Hashing: Audio CD (Track 2).bin
Hashing: Audio CD (Track 3).bin
Hashing: Audio CD (Track 4).bin
Hashing: Audio CD (Track 5).bin
Hashing: Audio CD (Track 6).bin
EndTime: 2023-04-05T14:12:43-0400
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE datafile PUBLIC "-//Logiqx//DTD ROM Management Datafile//EN" "http://www.logiqx.com/Dats/datafile.dtd">
<datafile>
  <header>
    <name>-insert name-</name>
    <description>-insert description-</description>
    <version>-insert version-</version>
    <date>-insert date-</date>
    <author>-insert author-</author>
    <homepage>-insert homepage-</homepage>
    <url>-insert url-</url>
  </header>
  <game name="Sounds-of-Eorzea-Testing">
    <category>Games</category>
    <description>Sounds-of-Eorzea-Testing</description>
    <rom name="Audio CD (Track 1).bin" size="119199360" crc="84994153" md5="71bafb2722ee09b1bfa35048baca80c3" sha1="8ba9a47fcf5620559f5dca089fad08240748759f" />
    <rom name="Audio CD (Track 2).bin" size="62438544" crc="c9dd4c6d" md5="a2ab0f0a21eeed33cfd076f6e8f7d7a0" sha1="34a646c83e2978d045700dbe50a6b9d6ab9ce46f" />
    <rom name="Audio CD (Track 3).bin" size="94776192" crc="847004b9" md5="e00a4975c6ab37db1575317c14020bfb" sha1="161c31ef9d7aa5192965594d56d1a75c3161e3ac" />
    <rom name="Audio CD (Track 4).bin" size="56812560" crc="7469a19d" md5="59aebe4e165939d14301fe62c40af7d7" sha1="b185f9b7b1db7156b129dc32df62bdb9df5578a8" />
    <rom name="Audio CD (Track 5).bin" size="134621424" crc="6c0dc9df" md5="17842f9eb39651224d5d25b09868c8ef" sha1="f8cec3d63c9193063ec207c9c02b14201cdeff51" />
    <rom name="Audio CD (Track 6).bin" size="70202496" crc="8fe93a2b" md5="928d9abb084bdcd84a583da6976e29a4" sha1="2169ef7547f6d4d30894b468c69a740366ad7b65" />
  </game>
</datafile>