saramibreak / DiscImageCreator

This is the disc (CD, GD, DVD, HD-DVD, BD, GC/Wii, XBOX, XBOX 360) and disk (Floppy, MO, USB etc) image creation tool
http://forum.redump.org/topic/10483/discimagecreator/
Apache License 2.0
513 stars 45 forks source link

Suggestion: don't use absolute paths in the logs #191

Closed mariomadproductions closed 1 year ago

mariomadproductions commented 1 year ago

Some people have expressed concern about hosting dumper's logs, because they may contain personal info (names) in the full absolute paths that exist in the log files. Could these be changed to relative paths, or could the windows user folder be censored automatically?

fuzz6001 commented 1 year ago

@mariomadproductions As far as I know, DIC does not output absolute paths. (unless received by argument). Perhaps the absolute paths included in the DIC output are those received from MPF.

fuzz6001 commented 1 year ago

That changed in MPF 2.5.

MPF 2.4

MPF2 4

MPF 2.5

MPF2 5

mariomadproductions commented 1 year ago

I mean the file that has the command line in it, e.g. track_20230309T204228.txt here. I think sometimes it may be necessary to provide the full path to DIC, but I'm not sure the full paths should necessarily be in the output.

fuzz6001 commented 1 year ago

In my opinion, it is self-responsibility.

For example, in my case:

..\Release_ANSI\DiscImageCreator cd g .\dump 24 /c2 20 /q /ns /sf 

Also, logging "as is" is generally useful for debugging.

mariomadproductions commented 1 year ago

In my opinion, it is self-responsibility.

For example, in my case:

..\Release_ANSI\DiscImageCreator cd g .\dump 24 /c2 20 /q /ns /sf 

Also, logging "as is" is generally useful for debugging.

True, but some redump moderators are saying it may be a reason not to share logs publicly, and I don't think we can say to users not to use their normal login for dumping, or to edit the output manually for every dump they make. I think it'd be sensible for DIC to at least have the option, but having it on by default wouldn't be a bad idea too.

fuzz6001 commented 1 year ago

I have no reason to oppose any more, so I will leave it to sarami's judgment.