saramibreak / DiscImageCreator

This is the disc (CD, GD, DVD, HD-DVD, BD, GC/Wii, XBOX, XBOX 360) and disk (Floppy, MO, USB etc) image creation tool
http://forum.redump.org/topic/10483/discimagecreator/
Apache License 2.0
513 stars 45 forks source link

BH16NS40 SVC Code NS40 didn't supported #194

Closed MrPepka closed 1 year ago

MrPepka commented 1 year ago

Version I'm using latest version Describe the bug The official list of supported drives mentions that the BH16NS40 is supported in DIC (http://wiki.redump.org/index.php?title=Optical_Disc_Drive_Compatibility), but it seems that only the SVC NS50 version works, while the older SVC NS40 version does not work in DIC (it says the drive does not support lead-out). The problem is that this is not true because the redumper works with this drive even with the opcode BE_CDDA. Will it be fixed?

Screenshots

2023-04-13 (3)
saramibreak commented 1 year ago

https://github.com/saramibreak/DiscImageCreator/blob/master/DiscImageCreator/check.cpp#L159 1.00 and 1.02 are supported. Is your "VendorSpecific" different? Is VendorSpecific needed anyway?

MrPepka commented 1 year ago

I have a different firmware (version 1.03) so I think you need to add this code fragment to the check.cpp file else if (!strncmp(pDevice->szProductRevisionLevel, "1.03", DRIVE_VERSION_ID_SIZE)) { if (!strncmp(pDevice->szVendorSpecific, "N0A03A0", 7)) { pDevice->by0xF1Drive = TRUE;

saramibreak commented 1 year ago

Added. DiscImageCreator_test.zip

MrPepka commented 1 year ago

OK CD dumping works but DIC crashes when trying to fix C2 errors. Is the problem C2 offset or something else?

saramibreak commented 1 year ago

If it's true, it's another issue.