search

saramibreak / DiscImageCreator

This is the disc (CD, GD, DVD, HD-DVD, BD, GC/Wii, XBOX, XBOX 360) and disk (Floppy, MO, USB etc) image creation tool
http://forum.redump.org/topic/10483/discimagecreator/
Apache License 2.0
513 stars 45 forks source link

Bug - DVD Mode - No error messages at all when /raw is used #205

Closed ehw closed 1 year ago

ehw commented 1 year ago

Version 20230504T032226 (Test version for #202 )

Describe the bug DiscImageCreator does not report any error messages that are reported by the drive when /raw is used.

This was in part probably caused by the change in order to silence the error spam when dumping Wii/GC with Plextors, which generated SCSI errors with every block read. However, doing so silenced legitimate errors too, which is making diagnostics pretty difficult with the /raw mode...

This affects any disc and drive reading method strictly when /raw mode is used.

The only solution I can think of is to reenable errors to propagate even though they might spam the console and log file a lot. Unless there's something specifically setup when Plextors are used with /raw for GameCube and Wii discs and where only certain messages returned with each initial read on a sector, maybe we have no choice but to allow all error messages to be printed...

I'm not sure what would be an ideal solution here...

saramibreak commented 1 year ago

DiscImageCreator_test.zip When only Plextor and Nintendo disc dumps, message is not shown.

ehw commented 1 year ago

This works, thank you!

I'll get back to #204 in a moment. I needed the error messages to return to diagnose the issue further as I wasn't sure if maybe the drive was returning something without me knowing.

ehw commented 1 year ago

It looks like the drive wasn't returning any errors when #204 occurred. But this is definitely good now. Feel free to merge. :)