saramibreak / DiscImageCreator

This is the disc (CD, GD, DVD, HD-DVD, BD, GC/Wii, XBOX, XBOX 360) and disk (Floppy, MO, USB etc) image creation tool
http://forum.redump.org/topic/10483/discimagecreator/
Apache License 2.0
509 stars 45 forks source link

Likely regression in track handling between versions `20240101T000844` and `20240401T222316` #275

Closed maxz closed 1 month ago

maxz commented 1 month ago

Version 64 bit, AnsiBuild, 20240401T222316

Describe the bug The first 75 sectors of the second track for the disc mentioned below are scrambled.

DIC treats the track as an audio track and descrambles the first 75 sectors. The latest version comes to a result which differs from version 20240101T000844 and also from Redumper. Redumper treats the whole track as a data track.

Also see: https://github.com/superg/redumper/issues/148 I first wrongly reported this as an issue in Redumper.

Disc title PC Action 9/99

Log files PCABONUS0999 (DiscImageCreator).zip PCABONUS0999 (Redumper).zip DIC 20240101T000844 and Redumper build 314: PC Action 1999-09 (Bonus-CD).zip

saramibreak commented 1 month ago

I was misled by this report. http://forum.redump.org/topic/53657/fixed-cdi-track-2-wrong-in-cdi-video-cd-titelneuheiten-ii95

Uploaded. Linux DiscImageCreator_test.tar.gz Windows DiscImageCreator_test.zip

Btw, it seems he is busy, but I'm not. Please report a bug firstly to me. Your report is always welcome, whatever it is.

maxz commented 1 month ago
Your provided test version produces the correct checksums again. ```
-insert name- -insert description- -insert version- -insert date- -insert author- -insert homepage- -insert url-
Games -insert description-
```
The log of the test version. ``` AppVersion 64 bit, AnsiBuild, 20240519T232943 /c2 val3 was omitted. set [0] /c2 val4 was omitted. set [0] valid extension was omitted. -> set .bin CurrentDirectory /tmp/PCABONUS0999 WorkingPath Argument: /tmp/PCABONUS0999/PCABONUS0999.bin FullPath: /tmp/PCABONUS0999/PCABONUS0999.bin Drive: / Directory: tmp/PCABONUS0999/ Filename: PCABONUS0999 Extension: .bin StartTime: 2024-05-19T19:41:18+0200 Set the drive speed: 7056KB/sec Block Size: 4096 Flagment Size: 4096 All Block Num: 24635381 Free Block Num: 2825099 Available Block Num: 1567141 I Node Num: 6275072 Free I Node Num: 4749567 Available I Node Num: 4749567 File System ID: 6749354239398096367 Mount Flag: 1024 Max Filename Length: 255 DiskSize of [/tmp/PCABONUS0999] Total: 100906520576 bytes Used: 89334915072 bytes --------------------------- Space: 11571605504 bytes => There is enough disk space for dumping Check if subchannel pack mode is supported [INFO] This drive supports subchannel pack mode Checking SubRtoW (Track) 13/13 This drive (CD-R PX-W4012A 1.07 03/22/06 09:00 ) supports [OpCode: 0xd8, SubCode: 0] This drive (CD-R PX-W4012A 1.07 03/22/06 09:00 ) supports [OpCode: 0xd8, SubCode: 1] This drive (CD-R PX-W4012A 1.07 03/22/06 09:00 ) supports [OpCode: 0xd8, SubCode: 2] This drive (CD-R PX-W4012A 1.07 03/22/06 09:00 ) supports [OpCode: 0xd8, SubCode: 8] Checking Pregap sync, msf, mode (LBA) -7843 Reading DirectoryRecord 21/ 21 LBA[000000, 0000000]: [F:ReadTOCText][L:546] Opcode: 0x43 ScsiStatus: 0x02 = CHECK_CONDITION SenseData Key-Asc-Ascq: 02-04-01 = NOT_READY - LUN_NOT_READY - BECOMING_READY LBA[000000, 0000000]: [F:ReadCDForCheckingSubQAdr][L:1109] Opcode: 0xd8 ScsiStatus: 0x02 = CHECK_CONDITION SenseData Key-Asc-Ascq: 06-29-00 = UNIT_ATTENTION - POWER ON, RESET, OR BUS DEVICE RESET OCCURRED Please wait for 40000 milliseconds until the device is returned lpCmd: d8, 00, 00, 00, 00, 00, 00, 00, 00, 02, 08, 00 dwBufSize: 5484 Checking SubQ adr (Track) 13/13 Creating (Track AA).bin & .sub (LBA) 330687/ 330687 There is not non-zero byte in the (Track AA) Creating (Track 00).scm & .sub, (Track 01)(-LBA).scm & .sub (LBA) -8508/ -10000 Set OpCode: 0xd8, SubCode: 8(Raw) Checking SubQ ctl (Track) 13/13 Creating .scm (LBA) 330588/330588 No C2 errors Copying .scm to .img Set LBA to descramble sector 330587/330587 Descrambling data sector of img: 200796/200796 Exec ./EccEdc.out check Sub "/tmp/PCABONUS0999/PCABONUS0999.img" Checking sectors: 330587/330587 [ERROR] Number of sector(s) where user data doesn't match the expected ECC/EDC: 75 Total errors: 75 Total warnings: 0 Creating cue and ccd (Track) 13/13 Creating bin (Track) 13/13 Hashing: PCABONUS0999.scm Hashing: PCABONUS0999.img Hashing: PCABONUS0999 (Track 01).bin Hashing: PCABONUS0999 (Track 02).bin Hashing: PCABONUS0999 (Track 03).bin Hashing: PCABONUS0999 (Track 04).bin Hashing: PCABONUS0999 (Track 05).bin Hashing: PCABONUS0999 (Track 06).bin Hashing: PCABONUS0999 (Track 07).bin Hashing: PCABONUS0999 (Track 08).bin Hashing: PCABONUS0999 (Track 09).bin Hashing: PCABONUS0999 (Track 10).bin Hashing: PCABONUS0999 (Track 11).bin Hashing: PCABONUS0999 (Track 12).bin Hashing: PCABONUS0999 (Track 13).bin EndTime: 2024-05-19T19:53:55+0200 ```

The tracks now match the old DIC version's and Redumper's results.

Btw, it seems he is busy, but I'm not. Please report a bug firstly to me. Your report is always welcome, whatever it is.

Alright. I will report messages which are connected to both programs here first, if you insist. Especially anything connected to scrambled sectors. So far I tried to determine the most likely source and then reported it where it seemed appropriate. But this makes it easier for me too.