search

saramibreak / DiscImageCreator

This is the disc (CD, GD, DVD, HD-DVD, BD, GC/Wii, XBOX, XBOX 360) and disk (Floppy, MO, USB etc) image creation tool
http://forum.redump.org/topic/10483/discimagecreator/
Apache License 2.0
534 stars 45 forks source link

Dump sector range (/ra) for BD discs too #287

Closed JohnVeness closed 1 week ago

JohnVeness commented 1 month ago

Is your feature request related to a problem? Please describe. Similar to issue #211 I have a Blu-ray disc that has an unreadable part. I'd like to be able to check how well cleaning the disc is working without having to dump the entire disc.

Describe the solution you'd like A way to dump a sector range on BDs, like the existing /ra option for DVDs.

Describe alternatives you've considered Putting up with the length of time it takes to dump from the start up to the bad patch!

Additional context Also, as far as I can see, the /ra option isn't documented anywhere, e.g. in the help text.

Thanks!

saramibreak commented 1 month ago

DiscImageCreator_test.zip added /ra to the bd command.

Also, as far as I can see, the /ra option isn't documented anywhere, e.g. in the help text.

Thanks.

JohnVeness commented 1 month ago

DiscImageCreator_test.zip added /ra to the bd command.

Thanks, although I'm running this on Linux. If you can point me to the source for this change, I can compile it...

saramibreak commented 1 month ago

Uploaded source code.

JohnVeness commented 1 month ago

Many thanks. I have tested that and it works as expected with a start and end argument :)

However, I notice that if I leave out one or both of the arguments after /ra, it will segmentation fault.

saramibreak commented 1 month ago

However, I notice that if I leave out one or both of the arguments after /ra, it will segmentation fault.

Tell me all arguments, plz.

JohnVeness commented 1 month ago

For example: DiscImageCreator bd /dev/sr0 DISCNAME 0 /q /d /rr /ra 100000 or DiscImageCreator bd /dev/sr0 DISCNAME 0 /q /d /rr /ra both of which segfault.

For interest (and this isn't really a feature request) I was trying the first form, with just the StartLBA, because I was hoping it would interpret that as meaning "dump from StartLBA to the end of the disc" and I hadn't yet looked up the end LBA of the disc. I only tried the second form to see if that would segfault too, which it did.

saramibreak commented 1 month ago

both of which segfault.

Fixed it.

JohnVeness commented 1 month ago

Thanks, that seems to work great :)

JohnVeness commented 1 month ago

Also note https://github.com/saramibreak/DiscImageCreator/commit/2bce5d166d518ed3bd8c1fb66909d41bdb34e8d3#r145248358 if you missed it...