saramibreak / DiscImageCreator

This is the disc (CD, GD, DVD, HD-DVD, BD, GC/Wii, XBOX, XBOX 360) and disk (Floppy, MO, USB etc) image creation tool
http://forum.redump.org/topic/10483/discimagecreator/
Apache License 2.0
541 stars 47 forks source link

CAB Extraction crashes DIC entirely #53

Closed Whovian9369 closed 4 years ago

Whovian9369 commented 4 years ago

DIC Crashes when trying to extract CAB files of a Windows 95 disc, and it's a very reproducible issue. I was trying to dump this disc for myself using DICUI - Version 1.16-317 from AppVeyor (which itself is using DIC x86, AnsiBuild, 20200604T002233) but for whatever reason, DIC tried extracting all the CAB (even without /sf being added to the original DIC Command as well) and then ended up crashing before it got to the actual dumping stage.

Example screenshot of error on a Windows 7 machine: DIC_Crash_CABExtracting_Win95

saramibreak commented 4 years ago

Cab extraction starts when /sf or /ns is used. I don't know the cause of the crashing issue yet.

Whovian9369 commented 4 years ago

Cab extraction starts when /sf or /ns is used. Did a test dump (one with CLI and DICUI) and the dumps worked since I didn't use /sf or /ns, despite earlier testing showing otherwise. Weird, but hey at least it worked there.

The crash is still an annoyance to worry about, anyway. Thanks for your time!

Whovian9369 commented 4 years ago

So was able to get the latest DIC running on Linux (with another disc that crashes DIC with this error on Windows) just fine, since it doesn't seem to do CAB Extraction/Examination on Linux.

Please double check to see if there's a solution with the specific programs you're using on the Windows builds, since something seems to be very stupidly wrong there. If there isn't a solution, please do disable the cab scan by default. (Maybe have it as an opt-in flag so people can still use/test it as they need to, but it isn't run as default?)

saramibreak commented 4 years ago

Uploaded test version. http://www.mediafire.com/file/eq80y20l9cwf48f/DiscImageCreator_test.7z/file

Whovian9369 commented 4 years ago

Works as expected, thank you!

Working log of same disc as original report, as ran via cmder | Using my BW-16D1HT drive for this test: https://mystb.in/raw/TexasMailsHungarian