saramibreak / DiscImageCreator

This is the disc (CD, GD, DVD, HD-DVD, BD, GC/Wii, XBOX, XBOX 360) and disk (Floppy, MO, USB etc) image creation tool
http://forum.redump.org/topic/10483/discimagecreator/
Apache License 2.0
541 stars 47 forks source link

fix createCmdFile arg #92

Closed Poliwrath closed 2 years ago

Poliwrath commented 3 years ago

The dump date file is using the compile time variable rather than the current time variable.

before:

AppVersion
        x86, AnsiBuild, 10/2/221T173132
StartTime: 2021-10-29T17:31:34-0400
createoropen: F:\xxx\DiscImageCreator-master\Release_ANSI\dump1_10/2/221T173132.txt
[F:createCmdFile][L:1521] GetLastError: 3, The system cannot find the path specified.

(fails since there's slashes, expecting directory)

after:

AppVersion
        x86, AnsiBuild, 10/2/221T173510
StartTime: 2021-10-29T17:35:12-0400
createoropen: F:\xxx\dump1_2021-10-29T17:35.txt
<succeeds>
Poliwrath commented 3 years ago

oh, the rest of the filename is removed after the colon... :44.txt...

Poliwrath commented 3 years ago

okay, I changed the filename format to %FT%H-%M-%S%z dump1_2021-10-29T18-09-21-0400.txt

saramibreak commented 3 years ago

The dump date file is using the compile time variable

Yes, it's the specification.

Poliwrath commented 3 years ago

oh, I see. should the szDateTime format be changed to remove the slashes? (filename-safe)

saramibreak commented 3 years ago

Original is no slashes. Did you add it?

AppVersion x86, AnsiBuild, 20211031T003359

Poliwrath commented 3 years ago

Nope, that's strange. buildDateTime.h's contents:

#define BUILD_DATE "10/2/221"
#define BUILD_TIME "180919"
saramibreak commented 3 years ago

That's weird. Please execute below by the command prompt.

echo %DATE%
echo %DATE:~-10,4%%DATE:~-5,2%%DATE:~-2%
Poliwrath commented 3 years ago
echo %DATE%
Mon 11/01/2021

echo %DATE:~-10,4%%DATE:~-5,2%%DATE:~-2%
11/0/221
saramibreak commented 3 years ago

fixed: https://github.com/saramibreak/DiscImageCreator/commit/d2f3a7f4ba56f90ec7aef9ea2f002004617edd18