sarbagyastha / youtube_player_flutter

A Flutter plugin for inline playback or streaming of YouTube videos using the official iFrame Player API.
https://youtube.sarbagyastha.com.np
BSD 3-Clause "New" or "Revised" License
705 stars 818 forks source link

Dependencies need updating: flutter_inappwebview #460

Closed jimmyff closed 2 years ago

jimmyff commented 3 years ago

Please update flutter_inappwebview to version 5. As you are using version 4, this relies on an old version of uuid (2.0) which is causing problems with newer dart packages.

willhaslett commented 3 years ago

Any workaround at present? (Other than undoing the dependency journey that was migration to Flutter 2)

jimmyff commented 3 years ago

Not that I have found, I tried dependency overrides but had no luck due to breaking changes introduced in newer versions.

Really hoping @sarbagyastha will update the package soon.

jimmyff commented 3 years ago

Found a PR with the update: https://github.com/sarbagyastha/youtube_player_flutter/pull/449 - I'm going to test this now

MeAtPros commented 3 years ago

@jimmyff when do you plan to implement it?

jonafeucht commented 3 years ago

There is a fork for youtube_player_iframe which fixes your problem. https://pub.dev/packages/youtube_plyr_iframe

subhendukundu commented 3 years ago

@jonatadashi that was my plan, then realized I am using youtube_player_flutter too. So there a need for an upgrade in youtube_player_flutter too :(

jimmyff commented 3 years ago

@MeAtPros I'm not implementing the change (I've previously sent PRs but @sarbagyastha doesn't tend to accept them). I'm just utilising the fix PR sent by filipedfs here: https://github.com/sarbagyastha/youtube_player_flutter/pull/449. I've forked his change and using it like so (I suggest you fork your own rather than using mine):


dependency_overrides:
  youtube_player_iframe:
    git:
      url: https://github.com/jimmyff/youtube_player_flutter.git
      path: packages/youtube_player_iframe

This will tide me over until @sarbagyastha accepts the PRs or updates the package himself.

willhaslett commented 3 years ago

fwiw, I recommend using @popshootjapan 's fork (master branch) for now. @filipedfs 's fork (migrate-null-safety branch) does not include updating inappwebview for the youtube_player_flutter package (only the iframe package), and when I added that update to its pubspec.yaml, I got build-time errors.

@popshootjapan 's fork ran fine, and includes a bunch of (hopefully sound!?) changes to support null safety.

dependency_overrides:
  youtube_player_flutter:
    git:
      url: https://github.com/popshootjapan/youtube_player_flutter.git
      path: packages/youtube_player_flutter

@sarbagyastha, with the last commit being 3 months ago, and no apparent movement here, what's the story on maintenance for this repo? Are you looking for community support in reviewing and merging PRs? I need something that I can count on in production.

UPDATE: One of the changes that @popshootjapan made for null safety was throwing a runtime error for me. I made my own fork and a couple of changes, and this is now working:

dependency_overrides:
  youtube_player_flutter:
    git:
      url: https://github.com/willhaslett/youtube_player_flutter.git
      path: packages/youtube_player_flutte
sarbagyastha commented 3 years ago

I was occupied with other stuffs for last couple of months. I'm planning to update the package within this week or next.

nimisis commented 3 years ago

Just wondering - any plans to update the dependencies?

timekone commented 2 years ago

This seems to be resolved. @jimmyff @sarbagyastha