Closed jimmyff closed 2 years ago
Any workaround at present? (Other than undoing the dependency journey that was migration to Flutter 2)
Not that I have found, I tried dependency overrides but had no luck due to breaking changes introduced in newer versions.
Really hoping @sarbagyastha will update the package soon.
Found a PR with the update: https://github.com/sarbagyastha/youtube_player_flutter/pull/449 - I'm going to test this now
@jimmyff when do you plan to implement it?
There is a fork for youtube_player_iframe which fixes your problem. https://pub.dev/packages/youtube_plyr_iframe
@jonatadashi that was my plan, then realized I am using youtube_player_flutter too. So there a need for an upgrade in youtube_player_flutter too :(
@MeAtPros I'm not implementing the change (I've previously sent PRs but @sarbagyastha doesn't tend to accept them). I'm just utilising the fix PR sent by filipedfs here: https://github.com/sarbagyastha/youtube_player_flutter/pull/449. I've forked his change and using it like so (I suggest you fork your own rather than using mine):
dependency_overrides:
youtube_player_iframe:
git:
url: https://github.com/jimmyff/youtube_player_flutter.git
path: packages/youtube_player_iframe
This will tide me over until @sarbagyastha accepts the PRs or updates the package himself.
fwiw, I recommend using @popshootjapan 's fork (master branch) for now. @filipedfs 's fork (migrate-null-safety branch) does not include updating inappwebview for the youtube_player_flutter
package (only the iframe package), and when I added that update to its pubspec.yaml, I got build-time errors.
@popshootjapan 's fork ran fine, and includes a bunch of (hopefully sound!?) changes to support null safety.
dependency_overrides:
youtube_player_flutter:
git:
url: https://github.com/popshootjapan/youtube_player_flutter.git
path: packages/youtube_player_flutter
@sarbagyastha, with the last commit being 3 months ago, and no apparent movement here, what's the story on maintenance for this repo? Are you looking for community support in reviewing and merging PRs? I need something that I can count on in production.
UPDATE: One of the changes that @popshootjapan made for null safety was throwing a runtime error for me. I made my own fork and a couple of changes, and this is now working:
dependency_overrides:
youtube_player_flutter:
git:
url: https://github.com/willhaslett/youtube_player_flutter.git
path: packages/youtube_player_flutte
I was occupied with other stuffs for last couple of months. I'm planning to update the package within this week or next.
Just wondering - any plans to update the dependencies?
This seems to be resolved. @jimmyff @sarbagyastha
Please update
flutter_inappwebview
to version 5. As you are using version 4, this relies on an old version of uuid (2.0) which is causing problems with newer dart packages.