some maintenance - Githubissues

sarbajitsaha / Batch-Uninstaller

Batch Uninstaller app for Android (works on rooted as well as non-rooted phones)

GNU General Public License v3.0

67 stars 16 forks source link

some maintenance #8

Closed TacoTheDank closed 5 years ago

TacoTheDank commented 5 years ago

delete .idea and extra .aar files
target android pie
java 1.8 compatibility
reformat code
rearrange strings.xml
migrate app to appCompat
dialogs lib 0.9.4.5 -> 0.9.6.0
recyclerviewhelper 27.1.0 -> 27.1.1
note that EasyLicensesDialog is deprecated, recommend switching to Licenser

sarbajitsaha commented 5 years ago

Thanks for the pull request.

I noticed that you have changed the license term "You should have received a copy" to "You should have received a donate_copy" in some of the .java files. I am guessing its a refactoring error. The current version is the correct one; please refer here - https://www.gnu.org/licenses/gpl-howto.en.html

Once its fixed, I will merge after doing a successful build.

TacoTheDank commented 5 years ago

yeah that was refactoring that changed those for some reason

TacoTheDank commented 5 years ago

@sarbajitsaha Just a reminding mention

TacoTheDank commented 5 years ago

Thanks :)