search

sarbbottam / eslint-find-rules

Find built-in ESLint rules you don't have in your custom config
http://npm.im/eslint-find-rules
MIT License
201 stars 33 forks source link

Doesn't find unused rules in @typescript-eslint/eslint-plugin #316

Closed himynameisdave closed 4 years ago

himynameisdave commented 4 years ago

I noticed that this newly added rule was added in @typescript-eslint/eslint-plugin, and I realized that it was not being found by this tool. 😦

Perhaps this is an issue with scanning monorepos?

ljharb commented 4 years ago

That rule requires v2.22.0, have you fully updated? This tool uses what’s installed locally.

himynameisdave commented 4 years ago

Thanks for the reply (and for contributing to this invaluable tool). 💯 👍

Yep I updated it the plugin locally, then ran my usual command which I would expect to have found those new rules added in v2.22.0.

If you need, I can push the plugin package bumps and you can try for yourself in my config repo?

ljharb commented 4 years ago

Sure, a repro repo would be most helpful.

himynameisdave commented 4 years ago

After testing this more locally, I have realized that I had misconfigured something (was running it against a configuration which didn't use this plugin), my bad!

Thanks for the help! 👍